DoAddCommand - Replacement for NonWorking .Object API#40
DoAddCommand - Replacement for NonWorking .Object API#40artschekoff wants to merge 5 commits intoipfs-shipyard:mainfrom
Conversation
| /// <param name="arg">Args</param> | ||
| /// <param name="options">Options</param> | ||
| /// <returns>Response</returns> | ||
| public async Task<ICollection<IpfsFile>> DoAddCommand( |
There was a problem hiding this comment.
The UploadAsync methods handles multipart form data for a given command. We shouldn't need to create a new method for this, especially not one this specific in a class this general.
Instead of this, we should just fix the existing FileSystem.AddDirectoryAsync method.
| /// IpfsFile | ||
| /// </summary> | ||
| [DataContract] | ||
| public class IpfsFile |
There was a problem hiding this comment.
Looks like this type was created for the DoAddCommand method created above, but we already have this in ipfs-net-core as IFileSystemLink and IMerkleLink, with a FileSystemLink implementation in this repo.
| @@ -0,0 +1,5 @@ | |||
| include .env | |||
There was a problem hiding this comment.
We don't need to include a makefile. The underlying commands are already as simple as can be, and our CI handles publishing updates to nuget.
| @@ -0,0 +1,31 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
We don't need to add a nuspec here, and these values are different from our published package.
|
Significant improvements around the FilestoreApi.AddAsync method have been made as of 0.6.0, and the deprecated |
2 participants
Details are here - #39